feat: INF-3764 add default timouts overwritable with input#127
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a configurable default job timeout to the repository’s reusable GitHub Actions workflows, so callers can override timeout behavior via a workflow input.
Changes:
- Introduces a
timeoutMinutesworkflow input (default40) on multiple reusable workflows. - Applies the input by setting
timeout-minutes: ${{ inputs.timeoutMinutes }}on the corresponding jobs (and propagates it to nested reusable workflow calls where applicable). - Adds a fixed
timeout-minutes: 40to a couple of non-reusable CI workflows/jobs.
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/yaml.yaml | Adds timeoutMinutes input and applies it via timeout-minutes to the YAML lint job. |
| .github/workflows/terraform.yaml | Adds timeoutMinutes input and applies it via timeout-minutes to the Terraform job. |
| .github/workflows/shell.yaml | Adds timeoutMinutes input and applies it via timeout-minutes to the ShellCheck job. |
| .github/workflows/release.yaml | Adds timeoutMinutes input and applies it via timeout-minutes to the Release Drafter job. |
| .github/workflows/python.yaml | Adds timeoutMinutes input and applies it via timeout-minutes to the Python job. |
| .github/workflows/preview.remove-tag.yaml | Adds timeoutMinutes input and applies it via timeout-minutes to the preview tag removal job. |
| .github/workflows/preview.build-image.yaml | Adds timeoutMinutes input and applies it via timeout-minutes to both preview build and PR comment jobs. |
| .github/workflows/pr.yaml | Adds timeoutMinutes input and applies it via timeout-minutes to PR labeling and title validation jobs. |
| .github/workflows/npm.yaml | Adds timeoutMinutes input and applies it via timeout-minutes to the npm publish job. |
| .github/workflows/kubernetes.yaml | Adds timeoutMinutes input, applies it to jobs, and forwards it into the nested build-image reusable workflow call. |
| .github/workflows/json.yaml | Adds timeoutMinutes input and applies it via timeout-minutes to the JSON lint job. |
| .github/workflows/js.yaml | Adds timeoutMinutes input and applies it via timeout-minutes to the JS job. |
| .github/workflows/docs.yaml | Adds timeoutMinutes input and applies it via timeout-minutes to the docs (jekyll) job. |
| .github/workflows/deployment.yaml | Adds timeoutMinutes input and applies it via timeout-minutes to the deployment job. |
| .github/workflows/container.yaml | Adds timeoutMinutes input and applies it via timeout-minutes to the container job. |
| .github/workflows/ci.update-major-version-tag.yaml | Adds a fixed timeout-minutes: 40 to the update-major-tag job. |
| .github/workflows/ci.pr.yaml | Adds a fixed timeout-minutes: 40 to the actionlint job. |
| .github/workflows/ci-requirements.yaml | Adds timeoutMinutes input (default 40) and sets job timeout-minutes accordingly. |
| .github/workflows/build-image.yaml | Adds timeoutMinutes input and applies it via timeout-minutes across build-image workflow jobs. |
andibeuge
approved these changes
May 26, 2026
Contributor
andibeuge
left a comment
andibeuge
left a comment
There was a problem hiding this comment.
I think the hard coded timeout is not necessary for the internal ci... pipelines - maybe consider removing them if you agree. There is no downside/upside in having them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding default timeouts that can be overwritten with an input
https://parcellab.atlassian.net/browse/INF-3764